Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sandboxfs: init at 0.2.0 #99353

Merged
merged 2 commits into from Oct 3, 2020
Merged

sandboxfs: init at 0.2.0 #99353

merged 2 commits into from Oct 3, 2020

Conversation

jeremyschlatter
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS doesn't build on macOS b/c of fuse dependency
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jeremyschlatter jeremyschlatter mentioned this pull request Oct 2, 2020
Open
danieldk
danieldk suggested changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Two small requested changes.

pkgs/tools/filesystems/sandboxfs/default.nix
sha256 = "Ia6rq6FN4abnvLXjlQh4Q+8ra5JThKnC86UXC7s9//U=";
};

cargoSha256 = "sha256-k303TjWG+n+/ZMmko84KJtYb7swuQ1ZJOc4Vq6aOhX0=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget if we already permit SRI hashes, but from a quick grep it seems that we have a lot of them already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I computed these hashes by setting these fields to the empty string and then copy-pasting the hash in the error message from nix-build. This is the format that nix-build used to print them. I'd be happy to switch to a different format if that's preferable.

pkgs/tools/filesystems/sandboxfs/default.nix Show resolved Hide resolved
pkgs/tools/filesystems/sandboxfs/default.nix Outdated Show resolved Hide resolved
@jeremyschlatter
Copy link
Contributor Author

Thanks for the review! I made those two small changes.

danieldk
danieldk approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99353 1

1 package built:
  • sandboxfs

@danieldk danieldk merged commit 87278e9 into NixOS:master Oct 3, 2020
@jeremyschlatter jeremyschlatter deleted the sandboxfs branch October 3, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeremyschlatter @danieldk