Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] precice: fix build, 2.0.2 -> 2.1.0, enable for darwin #99338

Merged
merged 3 commits into from Oct 2, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 1, 2020

Motivation for this change

ZHF: #97479

Backport of #99118

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cmake gets confused with python 3.8's version number, switch back to 3.7
for now until upstream's resolved that

(cherry picked from commit 5afdaa2)
(cherry picked from commit c943e6b)
(cherry picked from commit 509208e)
@risicle risicle changed the title precice: fix build, 2.0.2 -> 2.1.0, enable for darwin [20.09] precice: fix build, 2.0.2 -> 2.1.0, enable for darwin Oct 1, 2020
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Oct 2, 2020
@ofborg ofborg bot requested a review from Scriptkiddi October 2, 2020 03:24
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM macOS 10.14

@risicle risicle merged commit a5bf6a2 into NixOS:release-20.09 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants