Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode/vscodium: split update scripts #97938

Merged
merged 1 commit into from Oct 12, 2020

Conversation

samuela
Copy link
Member

@samuela samuela commented Sep 13, 2020

Motivation for this change

Recently the versions of vscode and vscodium have diverged (see VSCodium/vscodium#501), meaning that the updates for one package fail while the other succeeds. This PR splits up the update scripts so that one can be run with out the other and vice-versa.

Things done

Tested that both scripts still function as expected.

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, but maybe change the title of the commit & PR to match standard package conventions: e.g. vscode/vscodium: split update scripts

@samuela samuela changed the title Split up the vscode update.sh into separate vscode/vscodium update scripts vscode/vscodium: split update scripts Sep 14, 2020
Split up the vscode update.sh into separate vscode/vscodium update
scripts. Recently the versions of vscode and vscodium have diverged (see
VSCodium/vscodium#501), meaning that the updates for one package fail
while the other succeeds. This PR splits up the update scripts so that
one can be run with out the other and vice-versa.
@samuela
Copy link
Member Author

samuela commented Sep 14, 2020

Ok, done in 1692e2c.

@samuela
Copy link
Member Author

samuela commented Oct 11, 2020

Friendly ping on this. Anything else that needs to happen?

@drewrisinger
Copy link
Contributor

Not IMHO, but I don't have merge privileges. Pinging maintainers.

Copy link
Member

@Synthetica9 Synthetica9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but also don't have merge perms

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/245

@danieldk danieldk merged commit cffec69 into NixOS:master Oct 12, 2020
@samuela samuela deleted the samuela/split-vscode-updates branch October 12, 2020 22:28
@bobby285271 bobby285271 mentioned this pull request Aug 19, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants