New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode/vscodium: split update scripts #97938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM, but maybe change the title of the commit & PR to match standard package conventions: e.g. vscode/vscodium: split update scripts
Split up the vscode update.sh into separate vscode/vscodium update scripts. Recently the versions of vscode and vscodium have diverged (see VSCodium/vscodium#501), meaning that the updates for one package fail while the other succeeds. This PR splits up the update scripts so that one can be run with out the other and vice-versa.
347af23
to
1692e2c
Compare
Ok, done in 1692e2c. |
Friendly ping on this. Anything else that needs to happen? |
Not IMHO, but I don't have merge privileges. Pinging maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but also don't have merge perms
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
Recently the versions of vscode and vscodium have diverged (see VSCodium/vscodium#501), meaning that the updates for one package fail while the other succeeds. This PR splits up the update scripts so that one can be run with out the other and vice-versa.
Things done
Tested that both scripts still function as expected.