Stop violating not null constraint #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasJ
added a commit
to helsinki-systems/hydra
that referenced
this pull request
Sep 13, 2020
- Document the fields - Default most fields - Mostly validate fields - Allow rich values for `enabled` and `type` - Print all errors instead of only the first This also includes NixOS#811
edolstra
reviewed
Sep 14, 2020
src/lib/Hydra/Helper/AddBuilds.pm
Outdated
| @@ -57,7 +57,7 @@ sub updateDeclarativeJobset { | |||
| name => $name, | |||
| type => $data->{type} | |||
| }; | |||
| $row->{emailresponsible} = $data->{emailresponsible} if defined $data->{emailresponsible}; | |||
| $row->{emailresponsible} = $data->{emailresponsible} or 0; | |||
There was a problem hiding this comment.
Shouldn't this be // 0? I think or binds very weakly.
There was a problem hiding this comment.
But that doesn't matter, does it?
There was a problem hiding this comment.
Doesn't it parse as ($row->{emailresponsible} = $data->{emailresponsible}) or 0;? I could be wrong.
dhess
pushed a commit
to hackworthltd/hacknix
that referenced
this pull request
Sep 17, 2020
NixOS/hydra#811 This is currently wedging our Hydra.
dhess
pushed a commit
to hackworthltd/hacknix
that referenced
this pull request
Sep 17, 2020
NixOS/hydra#811 This is currently wedging our Hydra.
|
@edolstra Fixed and rebased |
dasJ
force-pushed
the
fix/override-constraint
branch
from
8213574
to
cb39225
Compare
Fixes this error: ERROR: failed to process declarative jobset test:inputs, DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute failed: ERROR: null value in column "emailoverride" violates not-null constraint
dasJ
force-pushed
the
fix/override-constraint
branch
from
cb39225
to
bd0ab9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error:
ERROR: failed to process declarative jobset test:inputs,
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st
execute failed: ERROR: null value in column "emailoverride" violates
not-null constraint
cc @basvandijk