Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chatterino2: 2.1.7 -> 2.2.2 #97914

Merged
merged 1 commit into from Sep 22, 2020
Merged

chatterino2: 2.1.7 -> 2.2.2 #97914

merged 1 commit into from Sep 22, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/kb9fqca9sy62537pig7hjbdnffdsda04-chatterino2-2.1.7 448.8M
/nix/store/vpxp3j7gb4rvld3gj4bjjjzqlp1gry95-chatterino2-2.2.2 449.1M

@drewrisinger
Copy link
Contributor

If you're updating, this package could use a little bit of formatting (e.g. nix-shell -p nixpkgs-fmt --run "nixpkgs-fmt ./pkgs/.../chatterino2/default.nix". Could also add meta.changelog = "https://github.com/Chatterino/chatterino2/blob/master/CHANGELOG.md";

cole-h
cole-h approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM (provided minor nit below is addressed). Also, worketh for me:

Result of nixpkgs-review pr 97914 1

1 package built:
  • chatterino2

pkgs/applications/networking/instant-messengers/chatterino2/default.nix Outdated Show resolved Hide resolved
@bbigras @cole-h
chatterino2: 2.1.7 -> 2.2.2
d8bc3fa 
Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
@bbigras
Copy link
Contributor Author

bbigras commented Sep 15, 2020

Done. Thanks.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/232

@bbigras
Copy link
Contributor Author

bbigras commented Sep 22, 2020

@marsam help merging this please

@marsam marsam merged commit fc7dbbd into NixOS:master Sep 22, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Sep 22, 2020

Thank you very much

@bbigras bbigras deleted the chatterino branch September 22, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bbigras @drewrisinger @nixos-discourse @cole-h @marsam