Make declarative jobsets a lot more usable #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beyond the merge conflicts present, I think this PR would be easier to review and merge if the validation of the data and fields were its own function, with tests written to cover at least its most important cases. I've rebased the rest of it (docs, the migration) in the attached patch, hopefully that helps: |
dasJ
force-pushed
the
feat/better-decl-jobsets
branch
2 times, most recently
from
3d17229
to
0e4d2e7
Compare
dasJ
force-pushed
the
feat/better-decl-jobsets
branch
from
0e4d2e7
to
2c1b712
Compare
|
cc @grahamc as your watch was probably dismissed by me marking this PR as a draft |
|
@grahamc Since this also fixes a bug I introduced, do you want me to make a PR with only that bugfix so it gets to master faster or does this have the change to be merged soon? |
|
Probably a good idea to make it a separate PR, even though I'd like to
merge this one soon too!
On March 11, 2021, GitHub ***@***.***> wrote:
@grahamc <https://github.com/grahamc> Since this also fixes a bug I
introduced, do you want me to make a PR with only that bugfix so it
gets to master faster or does this have the change to be merged soon?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#814 (comment)>, or
unsubscribe <https://github.com/notifications/unsubscribe-
auth/AAASXLDGLTXU5WSMSBC5XZDTDCPRPANCNFSM4RKXN5TQ>.
|
- Document the fields - Default most fields - Mostly validate fields - Allow rich values for `enabled` and `type` - Print all errors instead of only the first - Fix a bug in the project name PR that i recently introduced
dasJ
force-pushed
the
feat/better-decl-jobsets
branch
from
2c1b712
to
e2797df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabledandtypeErrors look like this: