Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-update: fix Darwin build #97945

Closed
wants to merge 1 commit into from
Closed

cargo-update: fix Darwin build #97945

wants to merge 1 commit into from

Conversation

happysalada
Copy link
Contributor

@happysalada happysalada commented Sep 14, 2020 •
edited

Motivation for this change

darwin build is broken https://hydra.nixos.org/build/126558524

Things done

apply a fix found by @danieldk (add a dependency that cc has)

@Gerschtli @filalex77 @JohnTitor
Let me know if anything.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 14, 2020
@danieldk
Copy link
Contributor

Just merged a fix into staging:

#97000

This change should not be necessary anymore with that PR merged.

@happysalada
Copy link
Contributor Author

Thanks!

@happysalada happysalada deleted the cargo-update/fix-darwin-build branch April 28, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@Gerschtli Gerschtli Awaiting requested review from Gerschtli

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@happysalada @danieldk