Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.httpx: fix tests #97899

Merged
merged 1 commit into from Sep 13, 2020
Merged

pythonPackages.httpx: fix tests #97899

merged 1 commit into from Sep 13, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 13, 2020

Motivation for this change

Test suite contained a literal timestamp which expired, causing all builds to fail, fixed upstream but not included in a release yet.

Suppose this counts towards ZHF #97479.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
pythonPackages.httpx: fix tests
92a9db2 
test suite contained a literal timestamp which expired, fixed upstream
@ofborg ofborg bot requested a review from costrouc September 13, 2020 12:00
@risicle
Copy link
Contributor Author

risicle commented Sep 13, 2020

@ofborg build python37Packages.httpx

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 97899 1

9 packages built:
  • datasette (python38Packages.datasette)
  • google-music-scripts
  • python37Packages.asgi-csrf
  • python37Packages.datasette
  • python37Packages.google-music
  • python37Packages.httpx
  • python38Packages.asgi-csrf
  • python38Packages.google-music
  • python38Packages.httpx

@mweinelt mweinelt merged commit e452e42 into NixOS:master Sep 13, 2020
@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 13, 2020
@mweinelt
Copy link
Member

Ported to 20.09 as 7cbec82.

@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @mweinelt