@jtojnar It doesn't seem to build man pages, but I think that is broken upstream. It also looks like it builds gtk-doc but that directory gets removed in the fixup phase? Maybe there is something wrong with the expression, I don't know how to debug that.

Multiple-outputs hook moves gtk-doc to devdoc output, or to /dev/null if the former is not available. Add outputs = [ "out" "devdoc" ]; between version and src attributes.

It does not look like there are man pages, the command for generating them is not invoked by anything: https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/blob/7b5321131a7516e1e309f48357fffa2ae909863d/docs/meson.build#L48-60

Thanks. I just did these fixes locally, I didn't know about GitHub's "Commit suggestion," it looks like it credits the commenter, is that the preferred approach? Also, this PR should wait until integration into gnome shell is released, since there is no UI for it right?

For trivial fixes like these, attribution is not necessary (and the extra commits will be squashed onto the original commit anyway).

Merging this is fine just for coverage. And it might be usefult if someone wants to control this using D-Bus or by applying the g-c-c patches to their system.

Added nixos test, should I squash commits?

I would say either is fine. As long as the individual commits evaluate they are okay.

Sorry, I forgot about this, should be good to go. Will merge once the CI succeeds.

One occurrence of stdenv.lib got through.

Closed by #112507

I feel this is problematic, because regardless whether user enabled power-profiles-daemon or not, if they use tlp, the assertion fails

Should not that assertion being in mkIf cfg.enable make it only trigger when user enabled p-p-d?

I'm still using TLP on my laptop since this commit, so must be something else going on if you are having a problem.

I just hit this,

❯ sudo nixos-rebuild switch
warning: Git tree '/etc/nixos' is dirty
warning: updating lock file '/etc/nixos/flake.lock':
* Updated 'nixpkgs': 'github:nixos/nixpkgs/1c16013bd6e94da748b41cc123c6b509a23eb440' -> 'github:nixos/nixpkgs/9468b073267c9159d79b89686fabd09367f74ac3'
warning: Git tree '/etc/nixos' is dirty
building the system configuration...
warning: Git tree '/etc/nixos' is dirty
error:
       Failed assertions:
       - You have set services.power-profiles-daemon.enable = true;
       which conflicts with services.tlp.enable = true;

The tlp setting seems to be coming from https://github.com/NixOS/nixos-hardware which I use.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cant-enable-tlp-when-upgrading-to-21-05/13435/4