Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pamqp: revert bump to fix pythonPackages.rabbitpy, bump pythonPackages.rabbitpy #97941

Merged
merged 2 commits into from Sep 23, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 13, 2020

Motivation for this change

ZHF: #97479

In attempting to fix pythonPackages.rabbitpy for ZHF I realized it wouldn't be possible with the recent bump of pythonPackages.pamqp, because no version of rabbitpy yet exists that supports pamqp 3.x. Seeing as there's only one other package (pythonPackages.aioamqp) depending on pamqp, and it seems fine with the old 2.3.0, I wondered if the best thing to do would be just to revert the bump for this release?

At the same time I bumped rabbitpy itself as I realized it was due.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

No version of pythonPackages.rabbitpy currently exists that supports 3.0.1

This reverts commit 4250cde.
@risicle
Copy link
Contributor Author

risicle commented Sep 14, 2020

@ofborg build python37Packages.rabbitpy

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97941 1

8 packages built:
  • python27Packages.pamqp
  • python27Packages.rabbitpy
  • python37Packages.aioamqp
  • python37Packages.pamqp
  • python37Packages.rabbitpy
  • python38Packages.aioamqp
  • python38Packages.pamqp
  • python38Packages.rabbitpy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants