Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 22d021337680
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 5e891fd07339
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Sep 13, 2020

  1. python3Packages.jenkinsapi: fix build 

    nix-env -f default.nix -iA python38Packages.jenkinsapi now works.

Here is a list of all the things done:
- fixed the dependency list which was lacking some packages
- changed checkPhase. This called python setup.py test by default,
which is very much not what jenkinsapi does upstream. This resulted in
simple_post_logger.py being imported, which called serve_forever(),
manifesting as a hang
- tox decided to install pbr every time and fails and also tried to
run tests across multiple python versions, so I just made checkPhase
call pylint/pycodestyle/py.test directly.
- disabled systests which try to run jenkins
- disabled misc broken tests. There are some calls in them that should
have been mocked but the mocks don't take effect for some reason,
resulting in failed requests to localhost.
- removed needless inputs. nose and unittest2 are not needed, not even
in python2
- disabled tests on darwin, as requests-kerberos is apparently broken
    @rski
    rski authored and Jon committed Sep 13, 2020
    Copy the full SHA
    5e891fd View commit details
    Browse the repository at this point in the history