Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldset NG: Fix hit-testing for the rendered legend #25515

Merged
merged 1 commit into from Sep 15, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 14, 2020

If LayoutNGFragmentTraversal is disabled, no one calls
NodeAtPoint() for the rendered legend. This CL fixes it by adding
LayoutNGFieldset::HitTestChildren() override so that it handles the
fieldset's rendered legend.

Bug: 1127743
Change-Id: Idb21c4dc198591509e4172d89dc84e379a12097f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409416
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806924}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

If LayoutNGFragmentTraversal is disabled, no one calls
NodeAtPoint() for the rendered legend. This CL fixes it by adding
LayoutNGFieldset::HitTestChildren() override so that it handles the
fieldset's rendered legend.

Bug: 1127743
Change-Id: Idb21c4dc198591509e4172d89dc84e379a12097f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409416
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806924}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants