New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uqm: fix build #97919
uqm: fix build #97919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Diff LGTM minus unnecessary patch file
- Commits LGTM
- Builds via
nix-review
https://github.com/NixOS/nixpkgs/pull/97919
1 package built:
uqm
Changed to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/NixOS/nixpkgs/pull/97919
1 package built:
uqm
@aanderse: Ah, thanks for pinging. You're correct that I didn't catch the @liff: What is the error you were getting about |
This is the error without the libpng patch:
uqm uses SDL_image to load the images and apparently SDL_image locates the appropriate libraries dynamically. uqm build never refers to libpng directly. Looks like adding |
So if that's the case, then we ideally should fix |
the tmp changes may no logner be necessary |
Yes, the build succeeds on current master (and 20.09). I've done no testing; I didn't even know the package. |
@aszlig Can you do that instead of adding the missing dependency to here? |
uqm builds and runs fine now. |
Motivation for this change
ZHF: #97479
Things done
/tmp
. Replaced with$TMP
.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)