Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wordgrinder: fix build #97911

Merged
merged 1 commit into from Sep 16, 2020
Merged

wordgrinder: fix build #97911

merged 1 commit into from Sep 16, 2020

Conversation

liff
Copy link
Contributor

@liff liff commented Sep 13, 2020

Motivation for this change

ZHF: #97479

Things done

Fix build error:

impure path `/tmp/wg-build/lua' used in link
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

risicle
risicle approved these changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, linux x86_64, macos 10.14

@risicle
Copy link
Contributor

risicle commented Sep 13, 2020

(still WFM)

@risicle risicle mentioned this pull request Sep 16, 2020
Closed
10 tasks
@Pamplemousse
Copy link
Member

LGTM 👍

@risicle risicle merged commit 5ace6ec into NixOS:master Sep 16, 2020
@liff liff deleted the zhf/wordgrinder branch September 17, 2020 04:24
@liff liff mentioned this pull request Sep 17, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liff @risicle @Pamplemousse