Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nwg-launchers: 0.2.0 -> 0.3.3; fix nwggrid not showing apps #97959

Merged
merged 1 commit into from Sep 21, 2020
Merged

[20.09] nwg-launchers: 0.2.0 -> 0.3.3; fix nwggrid not showing apps #97959

merged 1 commit into from Sep 21, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 14, 2020

(cherry picked from commit 1d5fb04)

original pr: #97920
upstream bug: nwg-piotr/nwg-launchers#74

Motivation for this change

nwggrid wasn't showing any apps because it didn't respect XDG's specs or something like that.

I'm not sure if it's a good enough reason for a backport since it's my first one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/ys5fpzziivrm1qk97z5khnfmfvpzqa91-nwg-launchers-0.2.0 294.6M
/nix/store/7g8rhw9zqss4p1zplcis456qy6r81r5j-nwg-launchers-0.3.3 294.7M

@bbigras bbigras added this to the 20.09 milestone Sep 15, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Sep 15, 2020

@GrahamcOfBorg build nwg-launchers

@bbigras
Copy link
Contributor Author

bbigras commented Sep 19, 2020

@NixOS/nixos-release-managers

@bbigras
Copy link
Contributor Author

bbigras commented Sep 19, 2020 •
edited

Oh I think I used nixos-20.09 instead of release-20.09. Should I cherry-pick the commit and force push?
done

jonringer
jonringer approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97959 1

1 package built:
  • nwg-launchers

@jonringer jonringer merged commit b11f962 into NixOS:release-20.09 Sep 21, 2020
@bbigras bbigras deleted the backport branch September 21, 2020 18:14
@bbigras
Copy link
Contributor Author

bbigras commented Sep 21, 2020

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbigras @jonringer