chez-modules: Fix path to csv-site. #97927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the installation path for chez modules no longer includes the Chez version. This fixes the build for chez-mit and chez-scmutils.
|
Ah yes, the |
|
It's funny that you mentioned it, I switched from Guix to Nix literally yesterday. I'm not sure how |
|
Two guix refugees meeting on a scheme PR, who would have thought Builds happily, linux x86_64 |
|
Also, welcome to nixpkgs! |
meithecatte
added a commit
to meithecatte/nixpkgs
that referenced
this pull request
Sep 16, 2020
As a follow-up to NixOS#97927, chez can now find its libraries in a nix-shell, and derivations for such libraries don't need to handle the search path themselves.
|
I've opened a follow-up PR that redoes this with a |
10 tasks
meithecatte
added a commit
to meithecatte/nixpkgs
that referenced
this pull request
Sep 24, 2020
As a follow-up to NixOS#97927, chez can now find its libraries in a nix-shell, and derivations for such libraries don't need to handle the search path themselves. (cherry picked from commit 8f60607)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It seems that the installation path for chez modules no longer includes
the Chez version. This fixes the build for
chez-mitandchez-scmutils.ZHF: #97479
Note: I have tried to load the libraries in a
nix-shell -p chez chez-scmutils, but it seems like some environment variables need to be set manually to get that working. I don't know whether that was the case beforehand. I suppose @jitwit or @thoughtpolice would know.Things done
sandboxinnix.confon non-NixOS linux)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)(no tests for chez found)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"Tested execution of all binary files (usually in(no binaries)./result/bin/)nix path-info -Sbefore and after)