cookie-store: Simplify usage of promise_rejects_js() #25508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to `await` on `promise_rejects_js()` when it is the last call in a test: just returning it achieves the same result and looks more idiomatic. Subsequently drop `async` from functions that no longer use `await`.
|
cc @ayuishii |
inexorabletash
approved these changes
Sep 14, 2020
|
I'm really sorry, I'm coming off as extremely negative here. I don't like this change, and I don't have any constructive feedback... the way to make it better is to leave the code as-is. I find tests harder to read after this PR. The mental model has an extra rule, so it's more complicated, and I don't see any benefits that justify the complexity. From a different angle, this feels like a manually-applied tail-call optimization, but for promises. |
|
Let's just drop this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to
awaitonpromise_rejects_js()when it is the lastcall in a test: just returning it achieves the same result and looks more
idiomatic. Subsequently drop
asyncfrom functions that no longer useawait.