Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] drawpile: fix build by adding libsecret #97956

Merged
merged 1 commit into from Sep 14, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Sep 14, 2020

Motivation for this change

ZHF: #97479

Backport of #97437

(cherry picked from commit 1c8d65f)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commit LGTM
  • Builds
https://github.com/NixOS/nixpkgs/pull/97956
1 package built:
drawpile

@risicle
Copy link
Contributor

risicle commented Sep 14, 2020

WFM linux x86_64

@risicle risicle merged commit be6fc63 into NixOS:release-20.09 Sep 14, 2020
@fgaz fgaz deleted the zhf-backports/drawpile branch September 14, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants