haskellPackages.sbv: fix tests #97958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-576
to
+587
| sed -i -e 's|"z3"|"${pkgs.z3}/bin/z3"|' Data/SBV/Provers/Z3.hs''; | ||
| sed -i -e 's|"abc"|"${pkgs.abc-verifier}/bin/abc"|' Data/SBV/Provers/ABC.hs | ||
| sed -i -e 's|"boolector"|"${pkgs.boolector}/bin/boolector"|' Data/SBV/Provers/Boolector.hs | ||
| sed -i -e 's|"cvc4"|"${pkgs.cvc4}/bin/cvc4"|' Data/SBV/Provers/CVC4.hs | ||
| sed -i -e 's|"yices-smt2"|"${pkgs.yices}/bin/yices-smt2"|' Data/SBV/Provers/Yices.hs | ||
| sed -i -e 's|"z3"|"${pkgs.z3}/bin/z3"|' Data/SBV/Provers/Z3.hs | ||
|
|
||
| sed -i -e 's|\[abc, boolector, cvc4, mathSAT, yices, z3, dReal\]|[abc, boolector, cvc4, yices, z3]|' SBVTestSuite/SBVConnectionTest.hs | ||
| ''; |
There was a problem hiding this comment.
I feel like this solution is somewhat unfortunate, since now sbv will have dependencies on these various solvers even if you don't use them.
But since this was the original way the package was setup (using sed to get a path to z3), I guess it we can continue using it like this.
Could you change the base branch for this to haskell-updates?
There was a problem hiding this comment.
Could you change the base branch for this to
haskell-updates?
Done
KaiHa
requested review from
alyssais,
edwtjo,
FRidh,
jonringer and
matthewbauer
as code owners
By patching paths of the external provers and excluding not available provers from the test. ZHF: NixOS#97479
ofborg
bot
added
6.topic: fetch
6.topic: GNOME
KaiHa
force-pushed
the
pr/haskell-sbv
branch
from
eda12b3
to
82954bd
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
10.rebuild-linux: 1
10.rebuild-linux: 1-10
6.topic: GNOME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By patching paths of the external provers and excluding not available
provers from the test.
ZHF: #97479
Motivation for this change
ZHF: #97479
Things done
Patching paths of the external provers and excluding not available
provers from the test.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)