Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] lefthook: use go 1.14 to build #97963

Merged
merged 1 commit into from Sep 25, 2020
Merged

[20.09] lefthook: use go 1.14 to build #97963

merged 1 commit into from Sep 25, 2020

Conversation

NobbZ
Copy link
Contributor

@NobbZ NobbZ commented Sep 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NobbZ
lefthook: use go 1.14 to build
9ace5b8 
Due to some changes in `go` from 1.14 to 1.15 the lefthook tool
currently can't start external programs and errors each test it tries
to run, making it effectively useless.

This is a temporary fix to make `lefthook` usable again until the
upstream issue was fixed and a new release has been cut.

Upstream issue: evilmartians/lefthook#151

(cherry picked from commit 4312e24)
@ofborg ofborg bot requested review from kalbasit and rencire September 14, 2020 07:39
@NobbZ NobbZ changed the title lefthook: use go 1.14 to build (backport to 20.09) [20.09] lefthook: use go 1.14 to build Sep 14, 2020
drewrisinger
drewrisinger approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commit LGTM
  • Builds
https://github.com/NixOS/nixpkgs/pull/97963
1 package built:
lefthook

@zimbatm zimbatm merged commit 53eac87 into NixOS:release-20.09 Sep 25, 2020
@avdv avdv mentioned this pull request May 26, 2021
Merged
@NobbZ NobbZ deleted the backport-lefthook-go-114-to-2009 branch July 24, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@rencire rencire Awaiting requested review from rencire

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NobbZ @drewrisinger @zimbatm