Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] lefthook: use go 1.14 to build #97964

Closed
wants to merge 1 commit into from
Closed

[20.03] lefthook: use go 1.14 to build #97964

wants to merge 1 commit into from

Conversation

NobbZ
Copy link
Contributor

@NobbZ NobbZ commented Sep 14, 2020

Motivation for this change

Due to some changes in go from 1.14 to 1.15 the lefthook tool
currently can't start external programs and errors each test it tries
to run, making it effectively useless.

This is a temporary fix to make lefthook usable again until the
upstream issue was fixed and a new release has been cut.

Upstream issue: evilmartians/lefthook#151

(cherry picked from commit 4312e24)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NobbZ
lefthook: use go 1.14 to build
fd37e92 
Due to some changes in `go` from 1.14 to 1.15 the lefthook tool
currently can't start external programs and errors each test it tries
to run, making it effectively useless.

This is a temporary fix to make `lefthook` usable again until the
upstream issue was fixed and a new release has been cut.

Upstream issue: evilmartians/lefthook#151

(cherry picked from commit 4312e24)
@NobbZ NobbZ changed the title lefthook: use go 1.14 to build (backport to 20.03) [20.03] lefthook: use go 1.14 to build Sep 14, 2020
@NobbZ
Copy link
Contributor Author

NobbZ commented Sep 18, 2020

I failed to do my homework correctly.

As there is actually no Go 1.15 in 20.03, this PR is actually not necessary.

I will assume that Go 1.15 will not be backported to 20.03 with 20.09 this near and close the PR.

@NobbZ NobbZ closed this Sep 18, 2020
@NobbZ NobbZ deleted the backport-lefthook-go-114-to-2003 branch September 18, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobbZ @drewrisinger