Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.48.2 -> 1.49.0 #97950

Closed
wants to merge 1 commit into from
Closed

vscode: 1.48.2 -> 1.49.0 #97950

wants to merge 1 commit into from

Conversation

JesusMtnez
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Synthetica9 and eadwu September 14, 2020 05:07
@cole-h cole-h mentioned this pull request Sep 14, 2020
Closed
@amaxine
Copy link
Member

amaxine commented Sep 14, 2020

Result of nixpkgs-review pr 97950 1

2 packages built:
  • vscode
  • vscode-with-extensions

amaxine
amaxine approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@amaxine amaxine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hashes match and it still runs :)

@austinbutler
Copy link
Member

This seems to be duplicated by #98088 and superseded by #98189.

@JesusMtnez JesusMtnez closed this Sep 21, 2020
@JesusMtnez JesusMtnez deleted the vscode branch September 21, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaxine amaxine amaxine approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JesusMtnez @amaxine @austinbutler