Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lefthook: use go 1.14 to build #97917

Merged
merged 1 commit into from Sep 13, 2020
Merged

lefthook: use go 1.14 to build #97917

merged 1 commit into from Sep 13, 2020

Conversation

NobbZ
Copy link
Contributor

@NobbZ NobbZ commented Sep 13, 2020

Motivation for this change

Due to some changes in go from 1.14 to 1.15 the lefthook tool
currently can't start external programs and errors each test it tries
to run, making it effectively useless.

This is a temporary fix to make lefthook usable again until the
upstream issue was fixed and a new release has been cut.

Upstream issue: evilmartians/lefthook#151

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixpkgs-review claims that there is no diff…

@NobbZ
lefthook: use go 1.14 to build
4312e24 
Due to some changes in `go` from 1.14 to 1.15 the lefthook tool
currently can't start external programs and errors each test it tries
to run, making it effectively useless.

This is a temporary fix to make `lefthook` usable again until the
upstream issue was fixed and a new release has been cut.

Upstream issue: evilmartians/lefthook#151
@endocrimes
Copy link
Member

Result of nixpkgs-review pr 97917 1

1 package built:
  • gitAndTools.lefthook

endocrimes
endocrimes approved these changes Sep 13, 2020
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for documenting the issue that's keeping it on 1.14 too. 👍

@ofborg ofborg bot requested review from kalbasit and rencire September 13, 2020 16:42
@marsam marsam merged commit 57f00c0 into NixOS:master Sep 13, 2020
@NobbZ NobbZ deleted the lefthook-go-114 branch September 14, 2020 04:31
@NobbZ NobbZ restored the lefthook-go-114 branch March 22, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@rencire rencire Awaiting requested review from rencire

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NobbZ @endocrimes @marsam