Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.vim-ocaml: init at 2020-08-20 #97935

Merged
merged 2 commits into from Sep 15, 2020
Merged

vimPlugins.vim-ocaml: init at 2020-08-20 #97935

merged 2 commits into from Sep 15, 2020

Conversation

trepetti
Copy link
Contributor

Motivation for this change

Add vim-ocaml plugin support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@trepetti
Copy link
Contributor Author

Not sure if all the intermediate commits generated by update.py should be rebased into one or not. I am guessing we should keep them all as separate concerns.

@ofborg ofborg bot requested review from jorsn and jagajaga September 13, 2020 22:47
@trepetti
Copy link
Contributor Author

Fixed merge conflicts caused by asyncomplete.vim fix in #97986.

jonringer
jonringer approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97935 1

2 packages built:
  • vimPlugins.coc-explorer
  • vimPlugins.vim-ocaml

@jonringer jonringer merged commit 89c781c into NixOS:master Sep 15, 2020
@trepetti trepetti deleted the vim-ocaml branch September 15, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jorsn jorsn Awaiting requested review from jorsn

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: vim 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trepetti @jonringer