Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restic: allow prune without backup #97937

Merged
merged 1 commit into from Mar 22, 2021
Merged

restic: allow prune without backup #97937

merged 1 commit into from Mar 22, 2021

Conversation

jerith666
Copy link
Contributor

@jerith666 jerith666 commented Sep 13, 2020 •
edited

Motivation for this change

fixes #97820

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jerith666 jerith666 force-pushed the restic-prune-only branch 2 times, most recently from 52978d1 to f60c6eb Compare September 13, 2020 21:51
cole-h
cole-h requested changes Sep 14, 2020
View reviewed changes
nixos/modules/services/backup/restic.nix Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Mar 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2021
@cole-h
Copy link
Member

cole-h commented Mar 20, 2021

I know this has been sitting dormant for a while (from before I even had commit access!), but could I also ask you to add a test for this to the restic test(s) in nixos/tests/restic.nix?

@jerith666
Copy link
Contributor Author

Done, thanks for the suggestion! :)

cole-h
cole-h approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I let this hang dormant for so long.

Diff LGTM. Thanks!

@cole-h cole-h merged commit 13bee29 into NixOS:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

restic: prune without backup
2 participants
@jerith666 @cole-h