Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal-desktop: fix test #97922

Merged
merged 1 commit into from Sep 21, 2020
Merged

signal-desktop: fix test #97922

merged 1 commit into from Sep 21, 2020

Conversation

KaiHa
Copy link
Contributor

@KaiHa KaiHa commented Sep 13, 2020 •
edited

Test was broken because network is not available during sandboxed test
run and therefore the expected text was never shown.

ZHF: #97479

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KaiHa
signal-desktop: fix test
ddd23d6 
Test was broken because network is not available during sandboxed test
run and therefore the expected text was never shown.

ZHF: NixOS#97479
@KaiHa
Copy link
Contributor Author

KaiHa commented Sep 14, 2020

Ping @NixOS/nixos-release-managers

vcunat
vcunat approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; /cc maintainer @flokli.

@vcunat vcunat merged commit cf09899 into NixOS:master Sep 21, 2020
@vcunat
Copy link
Member

vcunat commented Sep 21, 2020 •
edited

Looking now, I don't think the test was "reliably broken". On Hydra it usually succeeds and even for me locally; it was just luck that it failed the first time when I tested this, unless I made some mistake. All my builds and Hydra's should be sandboxed (except for fixed-output derivations but that's not this case).

@KaiHa
Copy link
Contributor Author

KaiHa commented Sep 21, 2020

I also realized that the test does not always fail. Sometimes after a long time the test succeeds. For further debugging I have added a ping right after the wait_for_text and it doesn't seem that the internet is available when the test succeeds. So I really have no clue what is going on there.

vcunat added a commit that referenced this pull request Sep 21, 2020
@vcunat
Merge #97922: nixosTests.signal-desktop: fix
cdf6be7 
(cherry picked from commit cf09899)
@vcunat
Copy link
Member

vcunat commented Sep 21, 2020

Ah, right, I missed the lengths of the runs – even locally, due to doing multiple things in parallel.

@KaiHa KaiHa deleted the master branch September 22, 2020 19:44
@avdv avdv mentioned this pull request May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KaiHa @vcunat @jonringer