CSS: Retire expansion-based implementation of :is and :where #25507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 13, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2405034
branch
4 times, most recently
from
0af7e74
to
d3026ab
Compare
We no longer attempt to expand :is and :where during style sheet loading. Correct support for these selectors remains to be implemented. In particular, we need: - invalidation - RuleFeatureSet - support for empty selector lists - error recovery - CSSSelectorParser Bug: 1127347 Change-Id: I28912cf5cb9b373c423d488b47c20251917329fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405034 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#808207}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2405034
branch
from
d3026ab
to
4d9ae21
Compare
|
The lint error is fixed in https://crrev.com/c/2417785 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer attempt to expand :is and :where during style sheet loading.
Correct support for these selectors remains to be implemented.
In particular, we need:
Bug: 1127347
Change-Id: I28912cf5cb9b373c423d488b47c20251917329fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405034
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808207}