Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.patdiff: init at 0.13 #99491

Closed
wants to merge 1 commit into from
Closed

Conversation

bcc32
Copy link
Contributor

@bcc32 bcc32 commented Oct 3, 2020

Motivation for this change

Patdiff is a diff tool and OCaml library optimized for code and config files, based on the Patience diff algorithm.

See also https://opensource.janestreet.com/patdiff/.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Oct 4, 2020

The package patdiff is already there: https://github.com/NixOS/nixpkgs/blob/3df7751051afe49fc1df71ef6151fa984126db55/pkgs/tools/misc/patdiff/default.nix (currently at version 0.13).

@bcc32
Copy link
Contributor Author

bcc32 commented Oct 4, 2020

Ah, you're totally right. I was looking for nixpkgs.ocamlPackages.patdiff and didn't find anything there, but it's at nixpkgs.patdiff instead.

@bcc32 bcc32 closed this Oct 4, 2020
@bcc32 bcc32 deleted the patdiff branch October 4, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants