Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various issues pointed out by CodeQL #22

Merged
merged 7 commits into from
Oct 3, 2020
Merged

Fix various issues pointed out by CodeQL #22

merged 7 commits into from
Oct 3, 2020
+267 −324

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Oct 3, 2020

I think that's most of them. PRing so I can see if there's anything left.

I've marked everything in bottle.py as "won't fix". I'd suggest that I'd report them upstream, but nah.

TrueBrain
TrueBrain reviewed Oct 3, 2020
View reviewed changes
TrueBrain
TrueBrain requested changes Oct 3, 2020
View reviewed changes
TrueBrain
TrueBrain approved these changes Oct 3, 2020
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LordAro LordAro merged commit ad65941 into OpenTTD:master Oct 3, 2020
@LordAro LordAro deleted the codeimprove branch October 3, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LordAro @TrueBrain