Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sawfish: fix build by replacing gdk-pixbuf with gdk-pixbuf-xlib #99483

Merged
merged 1 commit into from Oct 3, 2020
Merged

sawfish: fix build by replacing gdk-pixbuf with gdk-pixbuf-xlib #99483

merged 1 commit into from Oct 3, 2020

Conversation

mdevlamynck
Copy link
Contributor

Motivation for this change

Fix build of sawfish.
ZHF: #97479
@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from AndersonTorres October 3, 2020 16:33
@risicle
Copy link
Contributor

risicle commented Oct 3, 2020

Builds happily, non-nixos linux x86_64

AndersonTorres
AndersonTorres reviewed Oct 3, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndersonTorres AndersonTorres merged commit 11d1b7b into NixOS:master Oct 3, 2020
@worldofpeace
Copy link
Contributor

Feel free to backport 👍

@mdevlamynck mdevlamynck deleted the fix-sawfish-build branch October 4, 2020 08:48
@mdevlamynck mdevlamynck mentioned this pull request Oct 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdevlamynck @risicle @worldofpeace @AndersonTorres