Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.hidapi: fix build on darwin #99478

Merged
merged 1 commit into from Oct 4, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 3, 2020

Motivation for this change

ZHF: #97479

We have no need of this "xcrun" you speak of.

There are still some reverse-dependencies broken on macos that are opened up by the fixing of this. May address separately.

Also add pythonImportsCheck.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

also add pythonImportsCheck
@risicle risicle added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 3, 2020
@risicle
Copy link
Contributor Author

risicle commented Oct 3, 2020

@ofborg build python37Packages.hidapi python38Packages.hidapi

@risicle risicle marked this pull request as ready for review October 3, 2020 14:24
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Oct 3, 2020
@ofborg ofborg bot requested a review from np October 3, 2020 15:26
@mweinelt
Copy link
Member

mweinelt commented Oct 4, 2020

Result of nixpkgs-review pr 99478 1

1 package failed to build:
  • python27Packages.ledgerblue
29 packages built:
  • cm-rgb
  • electron-cash
  • electrum
  • hwi (python38Packages.hwi)
  • keepkey_agent (python38Packages.keepkey_agent)
  • ledger_agent (python38Packages.ledger_agent)
  • plover.stable
  • python27Packages.btchip
  • python27Packages.hidapi
  • python27Packages.python-u2flib-host
  • python37Packages.btchip
  • python37Packages.ckcc-protocol
  • python37Packages.hidapi
  • python37Packages.hwi
  • python37Packages.keepkey
  • python37Packages.keepkey_agent
  • python37Packages.ledger_agent
  • python37Packages.ledgerblue
  • python37Packages.python-u2flib-host
  • python37Packages.trezor
  • python37Packages.trezor_agent
  • python38Packages.btchip
  • python38Packages.ckcc-protocol
  • python38Packages.hidapi
  • python38Packages.keepkey
  • python38Packages.ledgerblue
  • python38Packages.python-u2flib-host
  • python38Packages.trezor
  • trezor_agent (python38Packages.trezor_agent)

@mweinelt mweinelt merged commit 9751fa8 into NixOS:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants