Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[haskell-updates] haskellPackages.haskell-language-server: 0.4.0 -> 0.5.0 #99508

Merged
merged 2 commits into from Oct 4, 2020
Merged

[haskell-updates] haskellPackages.haskell-language-server: 0.4.0 -> 0.5.0 #99508

merged 2 commits into from Oct 4, 2020

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Oct 3, 2020 •
edited

Motivation for this change

hls 0.5.0 has some amazing new features!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
Copy link
Member Author

maralorn commented Oct 3, 2020

@GrahamcOfBorg build haskellPackages.haskell-language-server

@maralorn maralorn mentioned this pull request Oct 4, 2020
Merged
10 tasks
@maralorn maralorn merged commit ac0ae05 into NixOS:haskell-updates Oct 4, 2020
@maralorn maralorn deleted the bump-hls branch October 4, 2020 02:08
peti pushed a commit that referenced this pull request Oct 9, 2020
@maralorn @peti
[haskell-updates] haskellPackages.haskell-language-server: 0.4.0 -> 0…
a605abd 
….5.0 (#99508)
peti pushed a commit that referenced this pull request Oct 9, 2020
@maralorn @peti
haskell-language-server: 0.4.0 -> 0.5.0 (#99508)
9bf8b98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout