Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.nbval: Fix tests #99489

Merged
merged 1 commit into from Oct 3, 2020
Merged

[20.09] python3Packages.nbval: Fix tests #99489

merged 1 commit into from Oct 3, 2020

Conversation

acairncross
Copy link
Contributor

Motivation for this change

Backport of #99475

ZHF: #97479

cc @jonringer @worldofpeace

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@acairncross
python3Packages.nbval: Fix tests
f27d909 
(cherry picked from commit a5f1cf9)
@mweinelt
Copy link
Member

mweinelt commented Oct 3, 2020

Result of nixpkgs-review pr 99489 1

7 packages built:
  • python27Packages.nbval
  • python37Packages.ipydatawidgets
  • python37Packages.nbval
  • python37Packages.onnx
  • python38Packages.ipydatawidgets
  • python38Packages.nbval
  • python38Packages.onnx

@mweinelt mweinelt merged commit 3d482c7 into NixOS:release-20.09 Oct 3, 2020
@acairncross acairncross deleted the fix-nbval-backport branch October 3, 2020 16:58
@acairncross acairncross changed the title [20.09] Fix nbval backport [20.09] python3Packages.nbval: Fix tests Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acairncross @mweinelt