Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.localzone: Downgrade dnspython dependency #99496

Merged
merged 1 commit into from Oct 4, 2020
Merged

python3Packages.localzone: Downgrade dnspython dependency #99496

merged 1 commit into from Oct 4, 2020

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Oct 3, 2020

The current localezone release is not compatible with dnspython 2.x that
was introduced in nixpkgs with commit a7b5b18

Motivation for this change

Fix broken build
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fadenb fadenb marked this pull request as draft October 3, 2020 18:15
@fadenb fadenb force-pushed the localzone_dnspython_downgrade branch from e3983fd to 7eddb66 Compare October 3, 2020 18:23
@fadenb fadenb marked this pull request as ready for review October 3, 2020 18:24
@mweinelt mweinelt changed the title python3Packages.localezone: Downgrade dnspython dependency python3Packages.localzone: Downgrade dnspython dependency Oct 3, 2020
@austinbutler austinbutler mentioned this pull request Oct 3, 2020
Merged
10 tasks
@fadenb fadenb force-pushed the localzone_dnspython_downgrade branch from 7eddb66 to 336d1be Compare October 4, 2020 13:03
python3Packages.localzone: Use dnspython_1
7a85f34 
localzone is currently incompatible with dnspython 2
@fadenb fadenb force-pushed the localzone_dnspython_downgrade branch from 336d1be to 7a85f34 Compare October 4, 2020 13:04
@fadenb
Copy link
Contributor Author

fadenb commented Oct 4, 2020

@mweinelt I adopted your recommended changes. Is this what you meant?

@mweinelt
Copy link
Member

mweinelt commented Oct 4, 2020

Yes, I feel this makes this change alot cleaner and better maintainable.

@mweinelt
Copy link
Member

mweinelt commented Oct 4, 2020

LGTM. What is broken, was broken before as well. Lexicon has alot of tests fail with regard to localzone though.

Result of nixpkgs-review pr 99496 1

2 packages failed to build:
  • ape
  • lexicon
2 packages built:
  • python37Packages.localzone
  • python38Packages.localzone

@mweinelt mweinelt merged commit 1d122a8 into NixOS:master Oct 4, 2020
FRidh
FRidh requested changes Oct 4, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Libraries cannot use a different version. If it is not compatible with the current dnspython it needs to be marked as broken.

@mweinelt
Copy link
Member

mweinelt commented Oct 4, 2020

So revert?

@FRidh
Copy link
Member

FRidh commented Oct 4, 2020

Yes

mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request Oct 4, 2020
@mweinelt
Revert "Merge pull request NixOS#99496 from fadenb/localzone_dnspytho…
6530c10 
…n_downgrade"

This reverts commit 1d122a8, reversing
changes made to 4304c70.

Quoting FRidh:
> Libraries cannot use a different version. If it is not compatible with the
> current dnspython it needs to be marked as broken.
@FRidh
Copy link
Member

FRidh commented Oct 4, 2020

#99567

@mweinelt mweinelt mentioned this pull request Oct 4, 2020
Merged
10 tasks
@jonringer
Copy link
Contributor

I already made an issue upstream ags-slc/localzone#1

jonringer pushed a commit that referenced this pull request Oct 4, 2020
@mweinelt @jonringer
Revert "Merge pull request #99496 from fadenb/localzone_dnspython_dow…
696731a 
…ngrade"

This reverts commit 1d122a8, reversing
changes made to 4304c70.

Quoting FRidh:
> Libraries cannot use a different version. If it is not compatible with the
> current dnspython it needs to be marked as broken.
@fadenb fadenb deleted the localzone_dnspython_downgrade branch October 4, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@mweinelt mweinelt mweinelt approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fadenb @mweinelt @FRidh @jonringer