Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmon: fix checkPhase #99482

Closed
wants to merge 1 commit into from
Closed

kmon: fix checkPhase #99482

wants to merge 1 commit into from

Conversation

jmpunkt
Copy link
Contributor

@jmpunkt jmpunkt commented Oct 3, 2020

Kmon contains tests which parse the given arguments. The argument
parser used in the test is the actual argument parser used by the Kmon
binary. By default Nix provides the --test-threads argument. This
argument can not be parsed by the Kmon parser, thus the test fails.

Motivation for this change

Building the package fails due to the checkPhase. By overwriting the checkPhase the problem is solved and the package builds properly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jmpunkt
kmon: fix checkPhase
a56f46e 
Kmon contains tests which parse the given arguments. The argument
parser used in the test is the actual argument parser used by the Kmon
binary. By default Nix provides the `--test-threads` argument. This
argument can not be parsed by the Kmon parser, thus the test fails.
@mdevlamynck
Copy link
Contributor

For information, it should be fixed in the next version if my PR is accepted orhun/kmon#23.

@ofborg ofborg bot requested a review from misuzu October 3, 2020 16:01
SuperSandro2000 added a commit to SuperSandro2000/nixpkgs that referenced this pull request Oct 10, 2020
@SuperSandro2000
kmon: 1.4.0 -> 1.5.1
2412389 
Closes NixOS#99482
@SuperSandro2000 SuperSandro2000 mentioned this pull request Oct 10, 2020
Merged
10 tasks
@jmpunkt jmpunkt deleted the kmon-fix-test-phase branch October 12, 2020 16:30
p-h pushed a commit to p-h/nixpkgs that referenced this pull request Oct 16, 2020
@SuperSandro2000 @p-h
kmon: 1.4.0 -> 1.5.1
52b7211 
Closes NixOS#99482

(cherry picked from commit 2412389)
@p-h p-h mentioned this pull request Oct 16, 2020
Merged
10 tasks
jonringer pushed a commit that referenced this pull request Oct 17, 2020
@SuperSandro2000 @jonringer
kmon: 1.4.0 -> 1.5.1
497baa1 
Closes #99482

(cherry picked from commit 2412389)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misuzu misuzu misuzu approved these changes

@fadenb fadenb fadenb approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmpunkt @mdevlamynck @misuzu @fadenb @SuperSandro2000