Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove trailing whitespaces in NFO output #164

Merged
merged 1 commit into from Oct 3, 2020
Merged

Fix: Remove trailing whitespaces in NFO output #164

merged 1 commit into from Oct 3, 2020

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Oct 2, 2020

Commit checker should now be happy.

@glx22 glx22 mentioned this pull request Oct 2, 2020
Merged
@glx22 glx22 changed the title Fix: Remove trailing whitespaces in output Fix: Remove trailing whitespaces in NFO output Oct 3, 2020
@LordAro
Copy link
Member

LordAro commented Oct 3, 2020

It's a bit odd that it's always a single space for every single line.. why is it there in the first place?

@glx22
Copy link
Contributor Author

glx22 commented Oct 3, 2020

It's there because all writes add it, as it's simpler to always add a space in case there's something written after.

@LordAro
Copy link
Member

LordAro commented Oct 3, 2020

Add a comment so it's obvious that's the reason?

@LordAro LordAro merged commit 49c5d50 into OpenTTD:master Oct 3, 2020
@glx22 glx22 deleted the whitespaces branch October 3, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glx22 @LordAro