Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencascade-occt, opencascade-occt730: fix build on darwin #99466

Merged
merged 1 commit into from Oct 3, 2020
Merged

opencascade-occt, opencascade-occt730: fix build on darwin #99466

merged 1 commit into from Oct 3, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 3, 2020 •
edited

Motivation for this change

ZHF: #97479

Now seems to need cocoa on macos.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 3, 2020
@ofborg ofborg bot requested review from amiloradovsky and gebner October 3, 2020 12:47
@gebner
Copy link
Member

gebner commented Oct 3, 2020

Do freecad and kicad build with this change?

@risicle
Copy link
Contributor Author

risicle commented Oct 3, 2020 •
edited

Well, it should be an identical build for linux and kicad & freecad don't seem to have ... ever? ... been enabled for darwin.

@gebner gebner merged commit d1614a3 into NixOS:master Oct 3, 2020
@gebner
Copy link
Member

gebner commented Oct 3, 2020

Backported as 9d31d9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiloradovsky amiloradovsky Awaiting requested review from amiloradovsky

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @gebner