Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: don't report SocketClosed when sending #34

Merged
merged 1 commit into from Oct 3, 2020
Merged

Fix: don't report SocketClosed when sending #34

merged 1 commit into from Oct 3, 2020

Conversation

TrueBrain
Copy link
Member

SocketClosed happens when the other side closed the connection,
and is pretty common in production. The caller knows how to handle
this signal just fine, so pass it through.

@TrueBrain
Fix: don't report SocketClosed when sending
940a78b 
SocketClosed happens when the other side closed the connection,
and is pretty common in production. The caller knows how to handle
this signal just fine, so pass it through.
@TrueBrain TrueBrain merged commit 51f3815 into OpenTTD:master Oct 3, 2020
@TrueBrain TrueBrain deleted the fix_socket_closed branch October 3, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @LordAro