Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixpkgs-review: 2.4.1 -> 2.4.2 #99481

Merged
merged 1 commit into from Oct 3, 2020
Merged

nixpkgs-review: 2.4.1 -> 2.4.2 #99481

merged 1 commit into from Oct 3, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 3, 2020 •
edited

Motivation for this change

allow for unfree packages to be built as well

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Oct 3, 2020

Awesome! Tested with the spotify package and works.

Result of nixpkgs-review pr 99481 1

1 package built:
  • nix-review (nixpkgs-review)

@mweinelt mweinelt merged commit 659f0e6 into NixOS:master Oct 3, 2020
@ofborg ofborg bot requested a review from Mic92 October 3, 2020 16:00
@jonringer jonringer deleted the bump-nixpkgs-review branch October 3, 2020 17:32
@Mic92
Copy link
Member

Mic92 commented Oct 4, 2020

Please also backport. We want stable users to have the same results on nixpkgs PRs as unstable users.

@mweinelt mweinelt mentioned this pull request Oct 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @mweinelt @Mic92