Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tarssh: init at 0.4.0 #99480

Merged
merged 1 commit into from Oct 29, 2020
Merged

tarssh: init at 0.4.0 #99480

merged 1 commit into from Oct 29, 2020

Conversation

Sohalt
Copy link
Contributor

@Sohalt Sohalt commented Oct 3, 2020

Motivation for this change

I want to use this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@omasanori
Copy link
Contributor

omasanori commented Oct 29, 2020 •
edited

Built and tested on NixOS 20.09 unstable x86_64, with or without -v and -l options, listen on IPv4 and IPv6. WFM.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/266

@AndersonTorres
Copy link
Member

Best motivation ever!

@AndersonTorres AndersonTorres merged commit 7cb747c into NixOS:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 left review comments

@omasanori omasanori omasanori approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Sohalt @omasanori @nixos-discourse @AndersonTorres @ajs124