Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fsspec: fix tests on linux #99499

Merged
merged 1 commit into from Oct 7, 2020
Merged

python3Packages.fsspec: fix tests on linux #99499

merged 1 commit into from Oct 7, 2020

Conversation

tricktron
Copy link
Member

@tricktron tricktron commented Oct 3, 2020 •
edited

Motivation for this change

Disables flaky test. Has been resolved in fsspec/filesystem_spec#432 and
can thus be enabled again starting from version 0.8.4.

ZHF: #97479
cc: @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tricktron
Copy link
Member Author

@grahamc I read on another issue thread that you are the guy who has some knowledge about hydra. Do you know what filesystem the x86_64-linux hydra builder use?

@grahamc
Copy link
Member

grahamc commented Oct 3, 2020

Some of them use ext4, some of them use ZFS.

@ofborg ofborg bot requested a review from costrouc October 3, 2020 19:30
@tricktron
Copy link
Member Author

@grahamc Thanks for the quick answer. Is there a way to find out if the machine here uses zfs or ext4? And is there a quick way to debug/test hydra darwin failures as mentioned here?

@risicle
Copy link
Contributor

risicle commented Oct 5, 2020

Are we merging this either way?

python3Packages.fsspec: fix tests on linux
0a9641b 
Disables flaky test. Has been resolved in fsspec/filesystem_spec#432 and
can thus be enabled again starting from version `0.8.4`.
@tricktron
Copy link
Member Author

@risicle @jonringer I think it is ready to merge. Btw: #98619 can't wait to be merged too.😃

risicle
risicle approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM macos 10.14, non-nixos linux x86_64

Hit the button.

@risicle risicle merged commit 889a785 into NixOS:master Oct 7, 2020
@tricktron tricktron deleted the fix-fsspec-linux-take2 branch October 8, 2020 05:02
@risicle risicle added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 8, 2020
@tricktron tricktron mentioned this pull request Oct 10, 2020
Merged
10 tasks
@sheepforce sheepforce mentioned this pull request Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tricktron @grahamc @risicle