Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofimoji: init at 4.3.0, wtype: init at 2020-09-14 #98972

Merged
merged 3 commits into from Sep 27, 2020
Merged

rofimoji: init at 4.3.0, wtype: init at 2020-09-14 #98972

merged 3 commits into from Sep 27, 2020

Conversation

justinlovinger
Copy link
Contributor

Motivation for this change

rofimoji is a unicode selector using Rofi. Now with Wayland support. Wayland support depends on wtype.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Okay, these expressions look all good. The issue now is we need to adhere with the commit policy.
The headers of the commits are good, it's just they need to be individual like

maintainers: add JustinLovinger
rofimoji: ...
wtype: ...

Could you fix this by doing a git reset @~1 --soft and re staging and committing them separate?

@justinlovinger
Copy link
Contributor Author

justinlovinger commented Sep 27, 2020 •
edited

Okay, these expressions look all good. The issue now is we need to adhere with the commit policy.
The headers of the commits are good, it's just they need to be individual like

maintainers: add JustinLovinger
rofimoji: ...
wtype: ...

Could you fix this by doing a git reset @~1 --soft and re staging and committing them separate?

@worldofpeace done :)

@worldofpeace worldofpeace merged commit 9f49623 into NixOS:master Sep 27, 2020
@worldofpeace
Copy link
Contributor

@justinlovinger Just merged. Thanks for the contribution ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinlovinger @worldofpeace @stigtsp