Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapcast: v0.20.0 → v0.23.0, including various fixes to nixos/snapserver #98962

Merged
merged 3 commits into from Feb 5, 2021
Merged

Snapcast: v0.20.0 → v0.23.0, including various fixes to nixos/snapserver #98962

merged 3 commits into from Feb 5, 2021

Conversation

zopieux
Copy link
Contributor

@zopieux zopieux commented Sep 27, 2020

Motivation for this change
  • New release.
  • The current module has out-of-date option examples and is missing stream types.
Things done

No significant change to package closure since there is no new dependency.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fpletz September 27, 2020 20:45
@zopieux zopieux changed the title Snapcast: v0.20.0 → v0.21.0, including various fixes to nixos/snapserver Snapcast: v0.20.0 → v0.22.0, including various fixes to nixos/snapserver Oct 25, 2020
greizgh
greizgh approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@greizgh greizgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built on nixos.
Client streams from server fine 👍

@zopieux
Copy link
Contributor Author

zopieux commented Nov 9, 2020 •
edited

@fpletz gentle ping :-)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 98962 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • snapcast

@zopieux
Copy link
Contributor Author

zopieux commented Feb 5, 2021

Hi @fpletz. Any chance you could give this PR a review please? It's currently preventing the use of new snapcast sources such as "tcp".

@zopieux
snapcast: v0.20.0 -> v0.23.0
5fd8747 
Includes dependency update: aixlog: v1.2.1 -> v1.4.0
@zopieux
nixos/snapserver: update available stream types for v0.21.0
a36cc03 
* Add 'librespot' (new name for 'spotify'), 'alsa', 'tcp'.
* Add a warning about the spotify -> librespot rename.
* Fix the deprecated example `mode = "listen"` for type 'pipe'.
* Update the tests to include a straightforward 'tcp' test.
@zopieux
nixos/snapserver: add AF_NETLINK to allowed address families
255882f 
This is necessary for Librespot, which is spawned by snapserver in the
same cgroup. Librespot requires querying local ip links and addresses
for MDNS (Zeroconf/Avahi), and does so through NETLINK interface.
@zopieux zopieux changed the title Snapcast: v0.20.0 → v0.22.0, including various fixes to nixos/snapserver Snapcast: v0.20.0 → v0.23.0, including various fixes to nixos/snapserver Feb 5, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/461

@7c6f434c 7c6f434c merged commit ce7da7d into NixOS:master Feb 5, 2021
@7c6f434c
Copy link
Member

7c6f434c commented Feb 5, 2021

If absolutely nobody cares to object…

@iblech
Copy link
Contributor

iblech commented Feb 5, 2021

This pull request looks very good to me. Thank you for your work, @zopieux! I'm sorry that merging took so long. Generally I am very happy with the fast turnaround time we have around here, but obviously there are big exceptions and I feel your frustration.

@zopieux
Copy link
Contributor Author

zopieux commented Feb 5, 2021

Thanks for the swift resolution in the end!

I'm sorry that merging took so long.

No worries, open-source work is best-effort.

@zopieux zopieux deleted the snapcast-fixes branch February 5, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greizgh greizgh greizgh approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zopieux @SuperSandro2000 @nixos-discourse @7c6f434c @iblech @greizgh