Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lndconnect: init at 0.2.0 #98969

Merged
merged 1 commit into from Jan 8, 2021
Merged

lndconnect: init at 0.2.0 #98969

merged 1 commit into from Jan 8, 2021

Conversation

d-xo
Copy link
Contributor

@d-xo d-xo commented Sep 27, 2020

Motivation for this change

Adds the lndconnect utility that is useful when setting up the zap Bitcoin lightning wallet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@d-xo d-xo requested a review from mmahut as a code owner September 27, 2020 20:53
@ProofOfKeags
Copy link
Contributor

How do I test/use this change on Linux?

mmilata
mmilata approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to produce working QR code on a nix-bitcoin instance using lndconnect --datadir=/var/lib/lnd --configfile=/var/lib/lnd/lnd.conf. LGTM!

@d-xo d-xo requested a review from RaghavSood as a code owner January 5, 2021 11:37
@d-xo
Copy link
Contributor Author

d-xo commented Jan 5, 2021

rebased on master, fixed typo.

@d-xo
Copy link
Contributor Author

d-xo commented Jan 7, 2021

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 7, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 7, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from timokau January 7, 2021 20:13
timokau
timokau approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good and nix-review passes. I have not tried to run it myself, but trust that you and @mmilata have. Thanks!

@timokau timokau merged commit 05983b1 into NixOS:master Jan 8, 2021
@ProofOfKeags
Copy link
Contributor

I cloned the fork and verified that the build works on non NixOS linux using nix-build and installing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@timokau timokau timokau approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@RaghavSood RaghavSood Awaiting requested review from RaghavSood RaghavSood is a code owner

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d-xo @ProofOfKeags @mmilata @timokau