Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.csexp: fix minimum OCaml version #98957

Merged
merged 1 commit into from Oct 1, 2020
Merged

ocamlPackages.csexp: fix minimum OCaml version #98957

merged 1 commit into from Oct 1, 2020

Conversation

hongchangwu
Copy link
Contributor

Motivation for this change

Source: https://opam.ocaml.org/packages/csexp/csexp.1.3.2/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions: Ubuntu
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hongchangwu hongchangwu mentioned this pull request Sep 27, 2020
Merged
10 tasks
@vbgl
Copy link
Contributor

vbgl commented Sep 28, 2020

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_02.csexp

vbgl
vbgl requested changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix the package before claiming it works!

@hongchangwu
Copy link
Contributor Author

hongchangwu commented Sep 28, 2020 •
edited

Apologies for not having done a more thorough test on this. I thought the OCaml 4.08 requirement was just about Dune 1 vs Dune 2. I now realize there is also the issue of result package not playing well with the Result module that was added to the standard library in 4.08 (and the postPatch added here as a workaround) . I'll update result to 1.5 (which is compatible for OCaml >= 4.08) and remove the postPatch step here.

@hongchangwu hongchangwu marked this pull request as draft September 30, 2020 03:41
@hongchangwu
Copy link
Contributor Author

@GrahamcOfBorg build ocamlPackages.dune-configurator ocaml-ng.ocamlPackages_4_02.csexp ocaml-ng.ocamlPackages_4_08.csexp

@hongchangwu
Copy link
Contributor Author

@GrahamcOfBorg build dot-merlin-reader

@hongchangwu hongchangwu marked this pull request as ready for review October 1, 2020 02:25
@hongchangwu hongchangwu requested a review from vbgl October 1, 2020 02:26
@vbgl
Copy link
Contributor

vbgl commented Oct 1, 2020

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_02.dune-configurator

@vbgl
Copy link
Contributor

vbgl commented Oct 1, 2020

There is something wrong about dune-configurator: probably a missing minumumOCamlVersion.

@hongchangwu
Copy link
Contributor Author

Yes, will fix in #99265

@vbgl vbgl merged commit f12817d into NixOS:master Oct 1, 2020
@vbgl
Copy link
Contributor

vbgl commented Oct 1, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hongchangwu @vbgl