Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sshping: fix build on darwin #98965

Merged
merged 1 commit into from Sep 27, 2020
Merged

sshping: fix build on darwin #98965

merged 1 commit into from Sep 27, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Sep 27, 2020

Fix hardcoded C++ compiler

Motivation for this change

ZHF 20.09 #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
sshping: fix build on darwin
e1d834a 
Fix hardcoded C++ compiler
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 27, 2020
@ofborg ofborg bot requested a review from jqueiroz September 27, 2020 21:08
@risicle
Copy link
Contributor

risicle commented Sep 27, 2020

WFM macos 10.14, linux x86_64, LGTM.

@risicle risicle merged commit 4e75022 into NixOS:master Sep 27, 2020
@r-burns r-burns deleted the sshping branch September 27, 2020 21:29
@r-burns r-burns mentioned this pull request Sep 27, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jqueiroz jqueiroz Awaiting requested review from jqueiroz

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-burns @risicle