Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greenfoot: init at 3.6.1 #98968

Merged
merged 1 commit into from Dec 6, 2020
Merged

greenfoot: init at 3.6.1 #98968

merged 1 commit into from Dec 6, 2020

Conversation

chvp
Copy link
Member

@chvp chvp commented Sep 27, 2020

Motivation for this change

I need it for a university course I'm a teaching assistent for. Heavily based on #98204, since the programs are very similar.

Things done

Running the program works. In the program, creating a new project, compiling a class and running a simulation works.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/398

@markuskowa markuskowa merged commit 46f7fbd into NixOS:master Dec 6, 2020
@chvp chvp deleted the pr/init-greenfoot branch December 6, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants