Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shotcut: 20.09.13 -> 20.10.31 #98964

Merged
merged 1 commit into from Nov 3, 2020
Merged

shotcut: 20.09.13 -> 20.10.31 #98964

merged 1 commit into from Nov 3, 2020

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Sep 27, 2020 •
edited

Motivation for this change

see https://github.com/mltframework/shotcut/releases/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wentasah
Copy link
Contributor

I run the shotcut binary on NixOS and it works as expected.

@woffs
Copy link
Contributor Author

woffs commented Oct 16, 2020

rebased to master and disabled the upgrade prompt

@woffs woffs marked this pull request as draft November 2, 2020 16:00
@woffs woffs changed the title shotcut: 20.09.13 -> 20.09.27 shotcut: 20.09.13 -> 20.10.31 Nov 2, 2020
@woffs
Copy link
Contributor Author

woffs commented Nov 2, 2020

Updated to recent version, rebased to master, and tested build and binary execution under x86_64

@peti
Copy link
Member

peti commented Nov 2, 2020

Why is this a draft?

@woffs woffs marked this pull request as ready for review November 3, 2020 04:14
@woffs
Copy link
Contributor Author

woffs commented Nov 3, 2020

Why is this a draft?

Just forgot to un-draft after updating and testing.

@peti peti merged commit a1d7a28 into NixOS:master Nov 3, 2020
@woffs woffs mentioned this pull request Nov 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woffs @wentasah @peti