ssm-agent: fix bad user declaration #99520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endgame
force-pushed
the
ssm-agent-user-fix
branch
from
4d499e5
to
4fa4118
Compare
endgame
force-pushed
the
ssm-agent-user-fix
branch
from
4fa4118
to
0d41792
Compare
infinisil
reviewed
Oct 7, 2020
| users.groups.ssm-user = {}; | ||
| users.users.ssm-user = { | ||
| isNormalUser = true; | ||
| group = "ssm-user"; |
There was a problem hiding this comment.
Is there a point to using a separate user if that user has the same privileges as root? Why not just run as root directly?
There was a problem hiding this comment.
Good question. The user is not used to run the service, it's used when you use Session Manager to connect directly to a running instance.
There was a problem hiding this comment.
(This does not appear to be a configurable thing, and is how it happens on standard AWS images too.)
|
@infinisil Thanks for your comments. Anything else you need from me to keep this moving? |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make
ssm-agentservice evaluate properly, and make Session Manager actually useful.Things done
Built and run on an EC2 nixos image, and connected to the system through AWS Systems Manager > Session Manager.