python3Packages.{irctokens,ircstates,ircrobots}: init #99521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 12 packages built:
|
jonringer
reviewed
Oct 4, 2020
| pytest-mock | ||
| ]; | ||
|
|
||
| disabledTests = lib.optional (!pythonOlder "3.8") [ |
There was a problem hiding this comment.
this is of shape [[string]]
Suggested change
| disabledTests = lib.optional (!pythonOlder "3.8") [ | |
| disabledTests = lib.optionals (!pythonOlder "3.8") [ |
There was a problem hiding this comment.
I always get those wrong. How do you remember which is which?
There was a problem hiding this comment.
optionals -> "many" -> an array
optional -> "one" -> singleton
Comment on lines
21
to
24
| checkInputs = [ | ||
| pytest-asyncio | ||
| #pytest-trio | ||
| #pytest-tornasync | ||
| #pytest-twisted | ||
| pytestCheckHook | ||
| #twisted | ||
| ]; |
There was a problem hiding this comment.
remove if not needed
Suggested change
| checkInputs = [ | |
| pytest-asyncio | |
| #pytest-trio | |
| #pytest-tornasync | |
| #pytest-twisted | |
| pytestCheckHook | |
| #twisted | |
| ]; | |
| checkInputs = [ | |
| pytest-asyncio | |
| pytestCheckHook | |
| ]; |
There was a problem hiding this comment.
Leftovers, had to choose one runtime to run the tests with. Removed!
| ircstates | ||
| async_stagger | ||
| async-timeout | ||
| ] ++ lib.optional (pythonOlder "3.7") [ |
There was a problem hiding this comment.
Suggested change
| ] ++ lib.optional (pythonOlder "3.7") [ | |
| ] ++ lib.optionals (pythonOlder "3.7") [ |
mweinelt
force-pushed
the
irc-stuff
branch
2 times, most recently
from
0a0c5f4
to
5f9181b
Compare
jonringer
reviewed
Oct 7, 2020
| propagatedBuildInputs = [ | ||
| idna | ||
| sniffio | ||
| ] ++ lib.optional (pythonOlder "3.8") [ |
There was a problem hiding this comment.
missed one ;)
Suggested change
| ] ++ lib.optional (pythonOlder "3.8") [ | |
| ] ++ lib.optionals (pythonOlder "3.8") [ |
|
Result of 12 packages built:
|
|
Result of 4 packages failed to build:
8 packages built:
|
|
@SuperSandro2000 Thanks. Your comment needs more build logs to be actionable. |
|
Sandbox failure: |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm writing software depending on these libraries.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)